feat(autonomous_emergency_braking): add virtual stop wall to aeb #7894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
requested review from
soblin,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
danielsanchezaran
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7894 +/- ##
==========================================
- Coverage 28.66% 28.64% -0.02%
==========================================
Files 1587 1589 +2
Lines 116302 116357 +55
Branches 49661 49667 +6
==========================================
Hits 33334 33334
- Misses 73890 73945 +55
Partials 9078 9078
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielsanchezaran
added
the
tag:update-codeowners-from-packages
|
@danielsanchezaran |
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Thanks for the comment, I believe there is a rendering issue. In some frames the wall looks good: and others where it seems a little disjointed: |
soblin
approved these changes
Jul 9, 2024
4 tasks
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 11, 2024
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 28, 2024
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2024
…owarefoundation#7894) * add virtual stop wall to aeb Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add maintainer Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add uppercase Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use motion utils function instead of shiftPose Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a virtual stop wall debug marker to the AEB module to facilitate visualization. It also adds a parameter to enable/disable the publishing of debug markers to speed up computation time if markers are not required.
Also added a maintainer.
Note: requires launch changes.
Related links
Parent Issue:
How was this PR tested?
PSim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.